policyd2

December 4th, 2008 by chifeng Leave a reply »

I ran into a few problems with this port. First of all you had a bad path in
one of your depends (fixed). But, the main problem is docs install. Several
points, the use of %%PORTDOCS%% in the pkg-plist is deprecated and being
removed from all ports. Secondly all ports now must respect NOPORTDOCS,
NOPORTEXAMPLES and NOPORTDATA. I fixed your install to respect these flags and
moved two folders out of ${DOCSDIR} that belong in ${DATADIR}. Try and avoid
using ${CP} and ${MKDIR} in the makefile. Also, it’s not necessary to list
your docs in the pkg-plist at all that’s now all handled by PORTDOCS= in the
Makefile same with PORTEXAMPLES and PORTDATA. If you have many files and
directories you can use the “*” (wildcard) character rather than clutter up
the Makefile. Rule of thumb is 4 lines of filenames max. Another point,  it’s
not a good idea to redefine ${DOCSDIR}. Users expect to find docs under the
portname in /usr/local/share/doc/${PORTNAME}, changing that to “cluebringer”
will only serve to confuse them. And finally, we never include the license in
docs. They are already in the tree and there are  already hundreds of copies

mistakenly put in docs.

Beech老大不厌其烦的解释了我port的这些问题,记录一下,以后注意不再犯错。
我立马改了,并且刚想upload了一个新的,还没来得及,再回头看邮件,发现Beech老大已经把patch发过来了。
服!!老大们总是喜欢直接给 patch!!
于是,又赶紧退回原来版本,测试了一下patch,没有问题,便回信告诉老大ci吧。。。
http://www.freebsd.org/cgi/query-pr.cgi?pr=129385
Advertisement

Leave a Reply